-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate communication setup channel with ipu-plugin #33
Conversation
b70660f
to
a54b820
Compare
note: this PR is currently using an overwritten dep in the go.mod as the upstream PR is not merged yet |
690d60f
to
1a1b648
Compare
@ahalimx86 @Eoghan1232 This code is ready to re-review. The go test command fails because some of the packages do not have tests - probably needs to be configured to exclude those packages [root@ipu-plugin]# go test -cover ./... |
b0b8559
to
7230b8a
Compare
go: updates to go.mod needed; to update it: can you fix the CI failure ? @palade |
Signed-off-by: Eoghan Russell <[email protected]>
@ahalimx86 Updated the go version in the ipu-plugin to match the version used by the dpu-operator . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds the code to integrate the communication setup channel functionality into the ipu-plugin.