Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate communication setup channel with ipu-plugin #33

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

palade
Copy link
Contributor

@palade palade commented Feb 27, 2024

This PR adds the code to integrate the communication setup channel functionality into the ipu-plugin.

@palade palade self-assigned this Feb 27, 2024
@palade palade force-pushed the andrei/add-comms-setup branch 4 times, most recently from b70660f to a54b820 Compare February 27, 2024 15:33
ipu-plugin/pkg/ipuplugin/vendorservice.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice_test.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice_test.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice_test.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice_test.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice_test.go Outdated Show resolved Hide resolved
@Eoghan1232
Copy link
Contributor

note: this PR is currently using an overwritten dep in the go.mod as the upstream PR is not merged yet
this PR should not be merged until this is resolved and pointed to the correct package.

ipu-plugin/go.mod Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/ipuplugin.go Outdated Show resolved Hide resolved
ipu-plugin/pkg/ipuplugin/vendorservice.go Outdated Show resolved Hide resolved
@palade palade force-pushed the andrei/add-comms-setup branch 4 times, most recently from 690d60f to 1a1b648 Compare March 2, 2024 14:50
@palade palade requested review from Eoghan1232 and ahalimx86 March 2, 2024 14:51
@palade
Copy link
Contributor Author

palade commented Mar 2, 2024

@ahalimx86 @Eoghan1232 This code is ready to re-review.

The go test command fails because some of the packages do not have tests - probably needs to be configured to exclude those packages

[root@ipu-plugin]# go test -cover ./...
? github.com/intel/ipu-opi-plugins/ipu-plugin/ipuplugin [no test files]
? github.com/intel/ipu-opi-plugins/ipu-plugin/ipuplugin/cmd [no test files]
? github.com/intel/ipu-opi-plugins/ipu-plugin/pkg/p4rtclient [no test files]
? github.com/intel/ipu-opi-plugins/ipu-plugin/pkg/types [no test files]
? github.com/intel/ipu-opi-plugins/ipu-plugin/pkg/utils [no test files]
ok github.com/intel/ipu-opi-plugins/ipu-plugin/pkg/ipuplugin 0.010s coverage: 59.1% of statements

@palade palade force-pushed the andrei/add-comms-setup branch 2 times, most recently from b0b8559 to 7230b8a Compare March 3, 2024 09:49
@Eoghan1232
Copy link
Contributor

go: updates to go.mod needed; to update it:
go mod tidy
make: *** [Makefile:52: test] Error 1
Error: Process completed with exit code 2.

can you fix the CI failure ? @palade

Signed-off-by: Eoghan Russell <[email protected]>
@palade
Copy link
Contributor Author

palade commented Mar 4, 2024

go: updates to go.mod needed; to update it: go mod tidy make: *** [Makefile:52: test] Error 1 Error: Process completed with exit code 2.

can you fix the CI failure ? @palade

@ahalimx86 Updated the go version in the ipu-plugin to match the version used by the dpu-operator .

Copy link
Contributor

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Eoghan1232 Eoghan1232 merged commit cf95d4d into intel:main Mar 4, 2024
9 checks passed
@palade palade deleted the andrei/add-comms-setup branch April 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants