Skip to content

Commit

Permalink
[CI] Add Windows BMG testing in precommit (#17105)
Browse files Browse the repository at this point in the history
We got a Windows BMG machine, so add Windows BMG testing.

There are two categories of failures here: consistent failures/timeouts
and really slow tests causing CI to take 30min extra.

I disabled both of these and made two GH issues:
[one](#17165),
[two](#17255).

---------

Signed-off-by: Sarnie, Nick <[email protected]>
  • Loading branch information
sarnex authored Mar 6, 2025
1 parent 8c5dbbd commit 2054243
Show file tree
Hide file tree
Showing 11 changed files with 38 additions and 2 deletions.
12 changes: 10 additions & 2 deletions .github/workflows/sycl-windows-precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,16 @@ jobs:
always()
&& !cancelled()
&& needs.build.outputs.build_conclusion == 'success'
strategy:
fail-fast: false
matrix:
include:
- name: Intel GEN12 Graphics with Level Zero
runner: '["Windows","gen12"]'
- name: Intel Battlemage Graphics with Level Zero
runner: '["Windows","bmg"]'
uses: ./.github/workflows/sycl-windows-run-tests.yml
with:
name: Intel GEN12 Graphics with Level Zero
runner: '["Windows","gen12"]'
name: ${{ matrix.name }}
runner: ${{ matrix.runner }}
sycl_toolchain_archive: ${{ needs.build.outputs.artifact_archive_name }}
3 changes: 3 additions & 0 deletions sycl/test-e2e/Adapters/level_zero_eager_init.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
// UNSUPPORTED-INTENDED: ze_debug UR emits summary of leaks that contains
// function names that we match in the test.

// XFAIL: windows && arch-intel_gpu_bmg_g21
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/17165

// RUN: %{build} -Wno-error=deprecated-declarations %level_zero_options -o %t.out
// RUN: env UR_L0_DEBUG=1 SYCL_EAGER_INIT=1 %{run} %t.out 2>&1 | FileCheck %s
//
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Adapters/level_zero_events_caching.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
// REQUIRES: gpu, level_zero

// UNSUPPORTED: windows && arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17255

// RUN: %{build} -o %t.out

// RUN: %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck --check-prefixes=CACHING-ENABLED %s
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: target-amd || target-nvidia
// XFAIL: windows && arch-intel_gpu_bmg_g21
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/17165
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

Expand Down
4 changes: 4 additions & 0 deletions sycl/test-e2e/Graph/RecordReplay/lit.local.cfg
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
config.required_features += ['aspect-ext_oneapi_limited_graph']

# https://github.com/intel/llvm/issues/17165
if 'windows' in config.available_features:
config.unsupported_features += ['arch-intel_gpu_bmg_g21']
4 changes: 4 additions & 0 deletions sycl/test-e2e/Graph/Update/lit.local.cfg
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
config.required_features += ['aspect-ext_oneapi_graph']

# https://github.com/intel/llvm/issues/17165
if 'windows' in config.available_features:
config.unsupported_features += ['arch-intel_gpu_bmg_g21']
Empty file removed sycl/test-e2e/Graph/lit.local.cfg
Empty file.
3 changes: 3 additions & 0 deletions sycl/test-e2e/KernelCompiler/kernel_compiler_sycl_jit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// UNSUPPORTED: windows && arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17255

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out 1
// RUN: %{l0_leak_check} %{run} %t.out 1
Expand Down
4 changes: 4 additions & 0 deletions sycl/test-e2e/Matrix/lit.local.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
# drivers version, so we temporarily mark it as unsupported (CMPLRLLVM-64705).
config.unsupported_features += ['spirv-backend']

# https://github.com/intel/llvm/issues/17165
if 'windows' in config.available_features:
config.unsupported_features += ['arch-intel_gpu_bmg_g21']

config.substitutions.append(("%helper-includes", "-I {}/Inputs".format(os.path.dirname(os.path.abspath(__file__)))))
original_clangxx=""
for substitution in config.substitutions:
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Regression/static-buffer-dtor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows

// UNSUPPORTED: windows && arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17255

#include <sycl/detail/core.hpp>

int main() {
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/WorkGroupMemory/basic_usage.cpp
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// UNSUPPORTED: windows && arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17255
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
#include <cassert>
Expand Down

0 comments on commit 2054243

Please sign in to comment.