[CI][HIP] Add missing dep for broken amd script. #13619
Conversation
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
gcc 13 should apparently be compatible with gcc12 for rocm 6.1..
| RUN ln -s -f /usr/bin/gcc-12 /usr/bin/gcc && \ | ||
| ln -s -f /usr/bin/g++-12 /usr/bin/g++ |
There was a problem hiding this comment.
I think proper way would be something using update-alternatives.
There was a problem hiding this comment.
Thanks, I've updated this now.
I've tested the latest commit now builds using g++12 for hip backend within a docker locally. Assuming that there is no backend that is incompatible with being built by g++12, this should now be safe.
Switch back to 12.1 (12.4 can be safely updated later). Signed-off-by: JackAKirk <[email protected]>
|
I think this needs to be split in two parts. First, fix the images but keep pre/post-commit running on old containers. Once merged and new images are verified locally we can switch the pre/post-commit tasks to use latest images once again. |
Signed-off-by: JackAKirk <[email protected]>
Makes sense to me. I've made this change. |
|
@intel/llvm-gatekeepers this is ready to merge Note that the containers for pre/post commit are currently fixed to an older version, so this will re-generate the latest but cannot break testing. |
This partially reverts the changes made in #13619 to use libstdc++-12-dev without gcc12. This also seems to work fine to build dpc++ within the docker. But should come without the CI failures that might have been induced by the gcc uplift: - #13736 - #13735 If the above issues were not caused by the gcc version uplift, then this patch should also reveal that. Signed-off-by: JackAKirk <[email protected]>
Fixes #13612
#13612 was caused by these issues:
ROCm/ROCm#2949
ROCm/HIP#3406
To fix this gcc/g++12 is installed manually and set as the preferred version.