Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Fix XPASS in kernel_info.cpp on FPGA #13626

Merged
merged 1 commit into from
May 1, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented May 1, 2024

Closes: #13615

@sarnex sarnex requested a review from a team as a code owner May 1, 2024 14:40
@sarnex sarnex changed the title [SYCL][E2E] Fix XPASS in kernel_info.cpp in FPGA [SYCL][E2E] Fix XPASS in kernel_info.cpp on FPGA May 1, 2024
@sarnex sarnex temporarily deployed to WindowsCILock May 1, 2024 15:09 — with GitHub Actions Inactive
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

// Consistently fails with opencl, enable when fixed.
// XFAIL: opencl
// Consistently fails with opencl non-fpga, enable when fixed.
// XFAIL: opencl && !accelerator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat surprised acc behaves differently from cpu... Anyway, not testable in pre-commit, so merging.

@aelovikov-intel aelovikov-intel merged commit d0b2432 into intel:sycl May 1, 2024
7 checks passed
@sarnex sarnex temporarily deployed to WindowsCILock May 1, 2024 16:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E] Basic/kernel_info.cpp XPASS'd on OpenCL FPGA after 2dae6cb
4 participants