-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Temporarily disable tests requiring spirv-tools
in CI
#16743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock fixing CI failures, but llvm-spirv
changes should either be upstreamed, or tracked in #7592 to remind us to revert them
I'm okay with merging this to fix post-commit. About the root cause, the problem seems to be that the path for all spirv-tools binaries is not found:
I'm not sure why, I cannot reproduce locally. If you help me reproduce the issue, I can try and fix it. |
Co-authored-by: Marcos Maronas <[email protected]>
spriv-tools
in CIspirv-tools
in CI
@intel/llvm-gatekeepers I think we are good to merge this. |
Hi @maarquitos14, @intel/dpcpp-spirv-reviewers, So, in
The installation package does not have the correct CMake target import file. Here's the import files
Notice the Solution: PS:- I've installed |
@uditagarwal97 Thanks for the thorough investigation! I'm good with the suggested solution, let me know if you need any help. |
`pkg-config` is required for `llvm-spirv` to detect `spirv-tools` installation. See #16743 (comment) for more info.
commit 7dec039 Author: Garcia Orozco, David <[email protected]> Date: Mon Jan 27 10:21:05 2025 -0800 remove IntelGPU folder, and add target-spir to lit.local.cfg commit dccac19 Author: Garcia Orozco, David <[email protected]> Date: Mon Jan 27 10:09:58 2025 -0800 Use target features instead of backend features commit be87b96 Merge: d83a37d e923fbb Author: Garcia Orozco, David <[email protected]> Date: Mon Jan 27 10:06:53 2025 -0800 Merge branch 'sycl' into inlineasm-litlocal commit e923fbb Author: Nick Sarnie <[email protected]> Date: Tue Jan 28 03:01:42 2025 +0900 [CI] Update dev-igc even if IGC CI failed (intel#16790) IGC public CI has been failing for months and we got confirmation even if the public CI fails the change has already been internally validated. We can confirm this change works as below: [Old link](https://api.github.com/repos/intel/intel-graphics-compiler/actions/workflows/build-IGC.yml/runs?status=success) [New link](https://api.github.com/repos/intel/intel-graphics-compiler/actions/workflows/build-IGC.yml/runs) Signed-off-by: Sarnie, Nick <[email protected]> commit 4eb095e Author: Chris Perkins <[email protected]> Date: Mon Jan 27 09:34:35 2025 -0800 [SYCL] remove experimental online_compiler extension (intel#16776) Minus support for "CM", all the functionality of the old experimental online_compiler extension is being provided by the new (also experimental) kernel_compiler. Only better. Besides always being merely experimental, the online_compiler has been marked as deprecated for over a year, it has become burdensome to continue to support, and it sometimes confuses users. The decision has been made to remove it, without waiting for an ABI breaking window. commit 566f514 Author: Udit Kumar Agarwal <[email protected]> Date: Mon Jan 27 09:27:27 2025 -0800 [CI] Install `pkg-config` in docker container (intel#16797) `pkg-config` is required for `llvm-spirv` to detect `spirv-tools` installation. See intel#16743 (comment) for more info. commit 367f355 Author: Mészáros Gergely <[email protected]> Date: Mon Jan 27 17:28:39 2025 +0100 [SYCL][E2E][NFC] Fix NameError if directive fails to parse (intel#16767) Currently if a test contains a malformed directive, the following exception is raised along with the original parsing error: ```plaintext Exception during script execution: (original error) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "llvm/llvm/utils/lit/lit/worker.py", line 76, in _execute_test_handle_errors result = test.config.test_format.execute(test, lit_config) File "llvm/sycl/test-e2e/format.py", line 232, in execute script = self.parseTestScript(test) File "llvm/sycl/test-e2e/format.py", line 105, in parseTestScript return lit.Test.Result(Test.UNRESOLVED, str(e)) NameError: name 'Test' is not defined ``` The test ends up as UNRESOLVED either way, but fixing it is easy and improves the error message greatly. commit d83a37d Author: Garcia Orozco, David <[email protected]> Date: Wed Jan 22 13:47:59 2025 -0800 Add `InlineAsm/IntelGPU` test directory commit 745d9b5 Merge: e91210e 34ef866 Author: Garcia Orozco, David <[email protected]> Date: Wed Jan 22 13:33:25 2025 -0800 Merge branch 'sycl' into inlineasm-litlocal commit e91210e Merge: 8d5f517 38e6e1b Author: Garcia Orozco, David <[email protected]> Date: Mon Jan 20 11:59:42 2025 -0800 Merge branch 'sycl' into inlineasm-litlocal commit 8d5f517 Author: Garcia Orozco, David <[email protected]> Date: Mon Dec 9 11:51:56 2024 -0800 Add REQUIRES: gpu,linux to lit.local.cfg commit a518866 Author: Garcia Orozco, David <[email protected]> Date: Mon Dec 9 11:44:21 2024 -0800 Use lit.local.cfg to mark cuda and hip as unsupported
…#16801) Reverts #16743. After installing `pkg-config` in CI, `llvm-spirv` can correctly find `spriv-tools` so this workaround is no longer needed. Example run: https://github.com/intel/llvm/actions/runs/12996166493/job/36244369469?pr=16801#step:14:16
#16724 installed
spirv-tools
on Linux docker containers and now some llvm-spirv tests are failing due to this (example: https://github.com/intel/llvm/actions/runs/12915358763/job/36017038536).In this PR, we disable detection of
spirv-tools
LIT feature temporarily in CI to fix post-commit.