Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Use target feature in 3 tests that explicitly set the triple #16828

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jan 29, 2025

These tests should only build on build-only if we have either target-nvidia or target-amd enabled. Currently they build regardless of what triples are available, and this was not detected because these tests set the triple explicitly rather than through the %{sycl_target_opts} expansion.

@ayylol ayylol requested review from a team as code owners January 29, 2025 13:50
@ayylol ayylol requested a review from againull January 29, 2025 13:50
@ayylol
Copy link
Contributor Author

ayylol commented Jan 29, 2025

Note: the two OptionalKernelFeatures tests never actually ran because of their faulty requirements. (Requiring two backends at once/two types of devices at once in an "and" statement). This wont fix that, but it will fix incorrectly building these tests when we dont have the amd/nvidia target enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants