Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Matrix][E2E] Add target-spir requirement to matrix tests #16855

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jan 31, 2025

Adds target-spir requirement to matrix tests that also require aspect-ext_intel_matrix since these tests do not build for any triples other than spir64.

@ayylol ayylol requested a review from a team as a code owner January 31, 2025 14:14
@dkhaldi
Copy link
Contributor

dkhaldi commented Jan 31, 2025

since these tests do not build for any triples other than spir64

The tests can also build for specific target values like intel_gpu_pvc

@ayylol
Copy link
Contributor Author

ayylol commented Jan 31, 2025

since these tests do not build for any triples other than spir64

The tests can also build for specific target values like intel_gpu_pvc

Would it be preferable to mark these instead with UNSUPPORTED: target-amd, target-nvidia, target-native_cpu? Those are the triples that i tested that didn't build.

Also curious, how are we currently testing for the other specific target values that you mention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants