Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Allow alignment property to be used for group load/store #16882

Merged
merged 9 commits into from
Feb 10, 2025
Merged

[SYCL] Allow alignment property to be used for group load/store #16882

merged 9 commits into from
Feb 10, 2025

Conversation

againull
Copy link
Contributor

@againull againull commented Feb 4, 2025 •
edited
Loading

It makes possible to provide alignment property to the load/store operations indicating the known alignment of the pointer. It will allow to avoid expensive dynamic alignment checks.

@againull againull requested review from a team as code owners February 4, 2025 16:03
@againull
Copy link
Contributor Author

againull commented Feb 4, 2025 •
edited
Loading

As far as I understand, another way of doing this will be to handle annotated_ptr with alignment property, and I will add that possibility separately. But currently annotated_ptr is only supported for pointers to the global address space (and here we need local address space support as well) and right now it is not clear to me how much work it requires to add local address space support to annotated_ptr and whether it makes sense. So this alternative approach gives immediate benefit for both local and global pointers.

@againull againull force-pushed the alignment_load_store branch from 1e118e5 to 936ddbf Compare February 4, 2025 16:10
@againull
[SYCL] Allow alignment property to be used for group load/store
f9fec27 
It makes possible to provide alignment<value> property to the
load/store operations indicating the alignment of the pointer.
It will allow to avoid expensive dynamic alignment checks.
@againull againull force-pushed the alignment_load_store branch from 122fab6 to f9fec27 Compare February 4, 2025 23:39
@againull againull mentioned this pull request Feb 5, 2025
Merged
@gmlueck
Copy link
Contributor

gmlueck commented Feb 5, 2025

As far as I understand, another way of doing this will be to handle annotated_ptr with alignment property, and I will add that possibility separately. But currently annotated_ptr is only supported for pointers to the global address space (and here we need local address space support as well) and right now it is not clear to me how much work it requires to add local address space support to annotated_ptr and whether it makes sense. So this alternative approach gives immediate benefit for both local and global pointers.

I don't think this is necessary. The APIs in this extension do not currently support annotated_ptr and they already take properties in another way.

@againull againull requested a review from gmlueck February 6, 2025 01:50
gmlueck
gmlueck approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec changes LGTM

againull added a commit that referenced this pull request Feb 7, 2025
@againull
[SYCL] Simplify group load/store implementation (#16890)
bc59e74 
Simplify handling of multiple address spaces and alignment checks.
Additional improvement regarding alignment checks is being done here (to
perform compile-time alignment check instead of expensive dynamic
check): #16882
Also this PR fixes alignment requirement for local address space:
16-byte alignment is required for both load and store.
@againull
Copy link
Contributor Author

againull commented Feb 7, 2025 •
edited
Loading

sampling_3D.cpp failure on HIP/AMD is unrelated and visible on other PRs, reported it here: #16933

@againull againull merged commit fcc330e into intel:sycl Feb 10, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@Pennycook Pennycook Pennycook left review comments

@gmlueck gmlueck gmlueck approved these changes

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@againull @gmlueck @bader @Pennycook @sergey-semenov