Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][NFC] Drop "vector_" prefix for vector tests. #17343

Merged
merged 1 commit into from
Mar 7, 2025
Merged

[SYCL][NFC] Drop "vector_" prefix for vector tests. #17343

merged 1 commit into from
Mar 7, 2025

Conversation

bader
Copy link
Contributor

@bader bader commented Mar 7, 2025

These tests are located in the directory named "vector", so adding
"vector_" prefix is unnecessary.

@bader
[SYCL][NFC] Drop "vector_" prefix for vector tests.
cb4b434 
These tests are located in the directory named "vector", so adding
"vector_" prefix is unnecessary.
@bader bader requested a review from a team as a code owner March 7, 2025 00:01
@bader bader requested a review from steffenlarsen March 7, 2025 00:01
@bader bader temporarily deployed to WindowsCILock March 7, 2025 00:02 — with GitHub Actions Inactive
@bader
Copy link
Contributor Author

bader commented Mar 7, 2025

@intel/dpcpp-devops-reviewers, it seems like one of the runners is unhealthy.

error: cannot lock ref 'refs/remotes/origin/main': Unable to create '/__w/repo_cache/intel/llvm/.git/refs/remotes/origin/main.lock': File exists.

Could you help to fix this issue, please?

@bader
Copy link
Contributor Author

bader commented Mar 7, 2025

FYI: my intention for this PR is to do only renaming to keep the change simple. I'm not going to address any other issues exposed by the pre-commit not related to renaming (e.g. clang-format check).

@bader bader temporarily deployed to WindowsCILock March 7, 2025 00:38 — with GitHub Actions Inactive
@bader bader temporarily deployed to WindowsCILock March 7, 2025 00:38 — with GitHub Actions Inactive
@uditagarwal97
Copy link
Contributor

@intel/dpcpp-devops-reviewers, it seems like one of the runners is unhealthy.

error: cannot lock ref 'refs/remotes/origin/main': Unable to create '/__w/repo_cache/intel/llvm/.git/refs/remotes/origin/main.lock': File exists.

Could you help to fix this issue, please?

Done. Here's the ongoing run on the same runner: https://github.com/intel/llvm/actions/runs/13710644540/job/38348127883?pr=17343

steffenlarsen
steffenlarsen approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@bader bader merged commit aecfc0e into intel:sycl Mar 7, 2025
34 of 39 checks passed
@bader bader deleted the tests-rename branch March 7, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bader @uditagarwal97 @steffenlarsen