[SPIR-V] W/A for builtin vars translation #7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/summary:run |
MrSidims
commented
Dec 4, 2022
|
/summary:run |
The translator was crashing in case if builin GV was accessed via GEP without AS cast due to incorrect assumption. This W/A is exclusive for intel/llvm Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
|
Need to add 51a49d2 as well |
Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
force-pushed
the
cherry-pick-wa
branch
from
1fb9fec to
1d302c7
Compare
|
@asudarsa please take a look. This issue affects pulldown. |
|
Proper testing is done in #7637 |
bader
approved these changes
Dec 6, 2022
|
@asudarsa friendly ping |
asudarsa
approved these changes
Dec 7, 2022
MrSidims
commented
Dec 7, 2022
|
@intel/llvm-gatekeepers please merge |
10 tasks
dm-vodopyanov
pushed a commit
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translator was crashing in case if builin GV was accessed via GEP without AS cast due to incorrect assumption. The W/A replaced GEP with ExtractElementInst.
This W/A is exclusive for intel/llvm . Proper fix is done in SPIR-V consumer, but it will take take time to have the drivers be updated in CI.
Signed-off-by: Sidorov, Dmitry [email protected]