compilersupport_p.h: add a macro for the fallthrough attribute

The /* fallthrough */ comment isn't always handled, causing some compilers to complain about falling through. Signed-off-by: Thiago Macieira <[email protected]>
intel · Feb 7, 2025 · ef1cb5a · ef1cb5a
1 parent 1bcde87
commit ef1cb5a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/cborparser.c b/src/cborparser.c
@@ -231,7 +231,7 @@ static CborError preparse_value(CborValue *it)
         case SinglePrecisionFloat:
         case DoublePrecisionFloat:
             it->flags |= CborIteratorFlag_IntegerValueTooLarge;
-            /* fall through */
+            CBOR_FALLTHROUGH;
         case TrueValue:
         case NullValue:
         case UndefinedValue:

diff --git a/src/compilersupport_p.h b/src/compilersupport_p.h
@@ -51,6 +51,20 @@
 #else
 #  define cbor_static_assert(x)         ((void)sizeof(char[2*!!(x) - 1]))
 #endif
+
+#if defined(__has_cpp_attribute)    // C23 and C++17
+#  if __has_cpp_attribute(fallthrough)
+#    define CBOR_FALLTHROUGH            [[fallthrough]]
+#  endif
+#endif
+#ifndef CBOR_FALLTHROUGH
+#  ifdef __GNUC__
+#    define CBOR_FALLTHROUGH            __attribute__((fallthrough))
+#  else
+#    define CBOR_FALLTHROUGH            do { } while (0)
+#  endif
+#endif
+
 #if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || defined(__cplusplus)
 /* inline is a keyword */
 #else