[Windows] [PT2.6] Add MSVC flag #945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuan14
reviewed
Sep 29, 2024
| @@ -24,6 +24,7 @@ add_library( | |||
| ${ATen_XPU_GEN_SRCS}) | |||
| install(TARGETS torch_xpu_ops_aten DESTINATION "${TORCH_INSTALL_LIB_DIR}") | |||
| # target_compile_definitions(torch_xpu_ops_aten PRIVATE CAFFE2_BUILD_MAIN_LIB) | |||
| target_compile_options(torch_xpu_ops_aten PRIVATE /permissive-) | |||
There was a problem hiding this comment.
What's the usage? Could you elaborate the add in the description of the commit.
Closed
|
@fengyuan14 the MSVC compiler faces issues with same namespace std being used in the code and this flag allows for stricter conformance and it is able to compile without running into ambiguous symbol std error |
ratnampa
changed the title
|
@fengyuan14 I no longer run into this error when building PT2.6 master with oneAPI 2025.0 dl-essentials-bundle. For now, I can close this and re-open if the same error occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.