Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27: regression fix of envfile.properties parent folder created #31

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

antoinetran
Copy link
Contributor

before

Summary

Fix regression introduced by #29 , because the parent directory does not exist for envfile.properties to be created. The directory is now created because the prepareMount create the directory, and only then the envfile.properties is created.

Related issue :

@dciangot dciangot self-requested a review October 14, 2024 13:15
Copy link
Collaborator

@dciangot dciangot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, confirm that is working. LGTM

@dciangot dciangot merged commit 576ca4e into interTwin-eu:main Oct 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants