Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy integration (gh pages) #21

Merged
merged 18 commits into from
Nov 5, 2024
Merged

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Nov 2, 2024

TODO

  • Open official netlify instance off this
  • Fix CORS (kapa integration)
  • add netlify secrets to github env

@Reecepbcups
Copy link
Contributor Author

Interesting that both GH pages & Netlify result in CORS errors for the Ask AI bot. But this does not happen when using my manual deploy on hetzner... hmm

@Reecepbcups
Copy link
Contributor Author

we prob have to get CORS approval from upstream, or need to somehow route this through an nginx RP (meh)

@Reecepbcups Reecepbcups changed the title feat: netlify integration feat: deploy integration (gh pages) Nov 5, 2024
@Reecepbcups
Copy link
Contributor Author

As we are waiting for the official netlify acc, I am going to launch from gh pages for the time being

@Reecepbcups Reecepbcups marked this pull request as ready for review November 5, 2024 16:31
@Reecepbcups Reecepbcups merged commit 5466866 into main Nov 5, 2024
1 check failed
@Reecepbcups Reecepbcups deleted the reece/netlify-integration branch November 8, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant