Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typings): remove and update some types #537

Merged

Conversation

vfreitas-
Copy link
Contributor

@vfreitas- vfreitas- commented Oct 1, 2020

What Changed

Helping in the issue #533

I have removed some unused typings and replaced them by the correct @types package.

Some considerations:

  • For the focus-lock package, it got TS support on the 0.8.0 version, so I did update it after checking for breaking changes.
  • The progress-estimator got TS support as well and have already been updated in the past 😄

Let me know if you need some change 😄

📦 Published PR as canary version: 2.6.1-canary.537.10781.0

✨ Test out this PR locally via:

npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
# or 
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]

@vfreitas- vfreitas- force-pushed the feature/issue-533-update-some-types branch from 99a378d to a104d38 Compare October 1, 2020 05:32
@vfreitas-
Copy link
Contributor Author

There are some errors on the build, I'll fix them 😄

@hipstersmoothie
Copy link
Contributor

Thanks! Sorry I didn't see this for so long, Renovate can hide stuff

@hipstersmoothie hipstersmoothie merged commit dbf5dd9 into intuit:master Mar 5, 2021
@hipstersmoothie hipstersmoothie added the skip-release Preserve the current version when merged label Mar 5, 2021
@hipstersmoothie
Copy link
Contributor

🚀 PR was released in v2.14.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants