Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: test case for undefined pathces #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drjova
Copy link
Contributor

@drjova drjova commented Apr 26, 2018

Signed-off-by: Harris Tzovanakis [email protected]

@drjova drjova requested a review from harunurhan April 26, 2018 12:14
@ghost ghost assigned drjova Apr 26, 2018
@ghost ghost added the Review: WIP label Apr 26, 2018
@harunurhan
Copy link
Contributor

harunurhan commented Apr 27, 2018

Quick fix for the test, would be adding empty array as default param to setJsonPatches.

Also optionally you would change your previous fix (184959b) by removing the if and putting a default empty array where we declared jsonPatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants