Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roles: changed need creation by role name to id #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

roles: changed need creation by role name to id #54

wants to merge 4 commits into from
+26 −7

Conversation

alejandromumo
Copy link
Member

@ntarocco
Copy link

ntarocco commented Aug 1, 2023

With tests failing, we might not be able to release this. It looks like that we might have to pin Flask?

@alejandromumo
Copy link
Member Author

With tests failing, we might not be able to release this. It looks like that we might have to pin Flask?

Seems to be the option, I think we already had to do it in other modules due to the deprecation of before_first_request.

ping @zzacharo

@ntarocco
Copy link

ntarocco commented Aug 7, 2023

We will need to check this together before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntarocco ntarocco ntarocco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roles: modify RoleNeed creation by role name to role id
3 participants
@alejandromumo @ntarocco @jrcastro2