I18n refactor commands #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since Transifex is used to manage translations, all we have to provide is a .pot file as a source. This will be pushed to Transifex. * English is the default language, so this is generated on extraction. * When pulling from Transifex, .po files will be generated/updated. * On package release, all available language files (.po) are compiled into .json files. These are then used by the application for lookup.
rekt-hard
force-pushed
the
i18n-refactor-commands
branch
from
6393075
to
7193e90
Compare
rekt-hard
commented
Oct 22, 2024
| @@ -44,7 +10,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "extract_messages": "i18next-scanner --config i18next-scanner.config.js '../../js/**/*.{js,jsx}'", | |||
| "postextract_messages": "i18next-conv -l en -s ./messages/en/translations.json -t ./translations.pot", | |||
| "postextract_messages": "i18next-conv -l en -s ./messages/en/translations.json -t ./translations.pot && i18next-conv -l en -s ./messages/en/translations.json -t ./messages/en/messages.po", | |||
There was a problem hiding this comment.
This will generate the .pot file for Transifex as well as the English .po file for the compilation process later.
rekt-hard
commented
Oct 22, 2024
Comment on lines
+29
to
+48
|
|
||
| # setup node | ||
| - name: Setup node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ env.NODE-VERSION }} | ||
|
|
||
| - name: Install deps for frontend translations | ||
| working-directory: ./invenio_requests/assets/semantic-ui/translations/invenio_requests | ||
| # installing from package-lock.json | ||
| run: | | ||
| npm ci | ||
| npm list | ||
|
|
||
| # compile frontend messages | ||
| - name: Compile frontend messages | ||
| working-directory: ./invenio_requests/assets/semantic-ui/translations/invenio_requests | ||
| run: | | ||
| npm run compile_catalog | ||
|
|
There was a problem hiding this comment.
It may make sense to move all of this to the reusable pypi publish workflow of inveniosoftware. More info can be found in the description of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
This PR tackles i18n management for the UI. This is done to have the same workflow as the backend and be consistent throughout the package. Additionally, non-mandatory files are removed, manual work is reduced and the workflow should be easier to understand.
Most important files for these changes are
.jsfiles. Changes in.po,.potand.jsonfiles are for cleanup and providing the current extraction for English.It would make sense to move the adaptations of the publish workflow to the reusable workflows repository (https://github.com/inveniosoftware/workflows/blob/master/.github/workflows/pypi-publish.yml). This will require to provide the translations path as an input as is done here:
invenio-requests/.github/workflows/tests.yml
Lines 34 to 37 in 5cba3e0
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: