Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): reduce tags #8932

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Conversation

matmair
Copy link
Member

@matmair matmair commented Jan 20, 2025

Reduces unneeded frontend related tags.
Dependant on #8874
Follow up to #6293

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 13b7f0f
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/679c0baa6f40b2000824178a

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (f7f6e27) to head (3f45592).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/InvenTree/helpers.py 83.33% 1 Missing ⚠️
...venTree/InvenTree/templatetags/inventree_extras.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8932      +/-   ##
==========================================
- Coverage   85.25%   85.16%   -0.10%     
==========================================
  Files        1175     1175              
  Lines       51925    51834      -91     
  Branches     2110     2110              
==========================================
- Hits        44271    44144     -127     
- Misses       7128     7157      +29     
- Partials      526      533       +7     
Flag Coverage Δ
backend 87.01% <85.71%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair changed the title WIP: refactor(backend): reduce tags refactor(backend): reduce tags Jan 26, 2025
@matmair
Copy link
Member Author

matmair commented Jan 27, 2025

@SchrodingersGat wdyt about these tags? Do you see any use for them after #6293 is merged?

@SchrodingersGat
Copy link
Member

These are all now provided via the API to the frontend code, right?

@matmair
Copy link
Member Author

matmair commented Jan 28, 2025

Yes - but not sure if they are used/useful in reports.

@wolflu05
Copy link
Contributor

I can see a lot of these tags being used in reports. Maybe we can move them all into one file related to the report app?

@matmair
Copy link
Member Author

matmair commented Jan 28, 2025

@wolflu05 can you be a bit more specific? Most of these tags were added for status or information modal or to control user specific rendering - which reports do not support IMO.

@wolflu05
Copy link
Contributor

I think the render_date tag would make sense to keep.

@matmair
Copy link
Member Author

matmair commented Jan 29, 2025

That makes sense, I can re-add that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants