-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend): reduce tags #8932
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8932 +/- ##
==========================================
- Coverage 85.25% 85.16% -0.10%
==========================================
Files 1175 1175
Lines 51925 51834 -91
Branches 2110 2110
==========================================
- Hits 44271 44144 -127
- Misses 7128 7157 +29
- Partials 526 533 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@SchrodingersGat wdyt about these tags? Do you see any use for them after #6293 is merged? |
These are all now provided via the API to the frontend code, right? |
Yes - but not sure if they are used/useful in reports. |
I can see a lot of these tags being used in reports. Maybe we can move them all into one file related to the report app? |
@wolflu05 can you be a bit more specific? Most of these tags were added for status or information modal or to control user specific rendering - which reports do not support IMO. |
I think the |
That makes sense, I can re-add that one |
Reduces unneeded frontend related tags.
Dependant on #8874
Follow up to #6293