Sales Order Barcode Allocate #8984
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SchrodingersGat
added
bug
|
@fuzeman nice catch, this seems like a sensible fix. Regarding the app - adding multiple shipment support is a great idea! If you are able to investigate that it would be fantastic. I'd be happy to help you get to know your way around the codebase |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable #8984 +/- ##
==========================================
- Coverage 84.61% 84.50% -0.11%
==========================================
Files 1201 1201
Lines 54684 54848 +164
Branches 2087 2088 +1
==========================================
+ Hits 46270 46350 +80
- Misses 7895 7978 +83
- Partials 519 520 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
…tion (#8984) (#8986) (cherry picked from commit ede30ce) Co-authored-by: Dean <[email protected]>
I've had a brief look at the codebase trying to track down this issue, and all appears to be fairly easy to follow. I'll let you know if I have any questions. What are you thinking long-term with the app? I'm more familiar with Flutter, but switching to react-native could be a consideration to enable the sharing of code with the new react interface. |
There are no plans to change to react native, although I have considered it (for code sharing purposes obviously). It would be a good move from that perspective but a LOT of work without any support or potential payoff. And we would need to ensure that all the current flutter libraries (which are already pretty fragile) have react native equivalents that work cross platform. Mobile dev sucks |
|
Yeah, good points. It sounds natural on the surface to merge/share code between the two, but I'm sure there will be a lot of pain along the way to achieve that. |
I discovered that when allocating items to a sales order by scanning stock item barcodes, once you complete the first shipment and move to another shipment, no stock items can be allocated to the new shipment.
As can be seen in the commit, previously with the
delivery_datefilter completed shipments would need a delivery date added before items could be allocated to a new shipment. Changing this toshipment_dateenables multiple shipments to be allocated and shipped together easily.Looking at the app, there probably should be a way to allocate into specific shipments. I might be able to take a look when I have some time, happen to use Dart + Flutter myself in a couple of production apps.