Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Hide empty args in about dialog #9033

Conversation

matmair
Copy link
Member

@matmair matmair commented Feb 4, 2025

This cleans up the "About" dialog a bit:

  • removes nulls from copy text
  • hides commit info if it is not available

@matmair matmair added the User Interface Related to the frontend / User Interface label Feb 4, 2025
@matmair matmair added this to the 1.0.0 milestone Feb 4, 2025
@matmair matmair self-assigned this Feb 4, 2025
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 5c77baf
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67a28448edf9340008452b24
😎 Deploy Preview https://deploy-preview-9033--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (no change from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.51%. Comparing base (e1f25a0) to head (5c77baf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...tend/src/components/modals/AboutInvenTreeModal.tsx 61.11% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9033      +/-   ##
==========================================
- Coverage   85.62%   85.51%   -0.12%     
==========================================
  Files        1177     1177              
  Lines       52012    52024      +12     
  Branches     2115     2118       +3     
==========================================
- Hits        44536    44488      -48     
- Misses       6928     6997      +69     
+ Partials      548      539       -9     
Flag Coverage Δ
pui 68.93% <61.11%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

"commit branch" looks wrong here:

image

@matmair
Copy link
Member Author

matmair commented Feb 4, 2025

The rendered args have not changed - is your testing environment providing that information in the old dialog?

@matmair
Copy link
Member Author

matmair commented Feb 4, 2025

If you are using the test deploy: for some reason the branch is not detected there
grafik

@SchrodingersGat SchrodingersGat merged commit 8bea3ca into inventree:master Feb 4, 2025
28 checks passed
@SchrodingersGat SchrodingersGat deleted the feat(frontend)--Hide-empty-args-in-about-dialog branch February 4, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants