fix!: push & unshift should accept undefined values to match be…

…haviour of `Array` (#35)
invertase · Aug 18, 2021 · c6b0265 · c6b0265
1 parent 5a2ba45
commit c6b0265
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -102,7 +102,7 @@ Denque.prototype.size = function size() {
  * @param item
  */
 Denque.prototype.unshift = function unshift(item) {
-  if (item === undefined) return this.size();
+  if (arguments.length === 0) return this.size();
   var len = this._list.length;
   this._head = (this._head - 1 + len) & this._capacityMask;
   this._list[this._head] = item;
@@ -132,7 +132,7 @@ Denque.prototype.shift = function shift() {
  * @param item
  */
 Denque.prototype.push = function push(item) {
-  if (item === undefined) return this.size();
+  if (arguments.length === 0) return this.size();
   var tail = this._tail;
   this._list[tail] = item;
   this._tail = (tail + 1) & this._capacityMask;

diff --git a/test/denque.js b/test/denque.js
@@ -90,6 +90,13 @@ describe('Denque.prototype.push', function () {
     assert(ret === 0);
   });
 
+
+  it('Should accept undefined values', function () {
+    var a = new Denque();
+    a.push(undefined);
+    assert(a.length === 1);
+  });
+
   it('Should add falsey elements (except undefined)', function () {
     var a = new Denque();
     // var before = a.length;
@@ -163,6 +170,12 @@ describe('Denque.prototype.unshift', function () {
     assert(ret === 0);
   });
 
+  it('Should accept undefined values', function () {
+    var a = new Denque();
+    a.unshift(undefined);
+    assert(a.length === 1);
+  });
+
   it('Should unshift falsey elements (except undefined)', function () {
     var a = new Denque();
     // var before = a.length;