-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore, iOS): account for filters in getAggregateFromServer with collection groups #8259
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
34e8385
to
7f3db39
Compare
…h collection groups
…h collection groups
7f3db39
to
efa81ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Worth creating a couple of e2e tests specifically for collectionGroup here: https://github.com/invertase/react-native-firebase/blob/vertexai/packages/firestore/e2e/Aggregate/AggregateQuery.e2e.js#L103
Create a separate describe('collectionGroup') , and test count(), average() and sum() to ensure they all work 😄
@russellwheatley, added test. |
@SelaseKay - Could you format the file? Might be able to do it in the file with keyboard shortcut. Alternatively, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
@russellwheatley , resolved |
ee4500a
to
a72928a
Compare
@SelaseKay - did you merge with main? I'm seeing code that is already in main branch. |
@russellwheatley, merged main into firestore_8253 and pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me @SelaseKay - nice
I left a confirmation comment for the original issue reporter to make certain the fix was only needed for iOS. By my analysis this is the complete fix because I think android was already working correctly but best to ask... #8253 (comment)
Related issues
Fixes #8253
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter