-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/computeshaders #250
Conversation
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
Used clang-tidy v17.0.6
Only 7 out of 8 clang-tidy concerns fit within this pull request's diff.
Click here for the full clang-tidy patch
diff --git a/misc/computeshaderexamples/src/processors/computeshaderimageexample.cpp b/misc/computeshaderexamples/src/processors/computeshaderimageexample.cpp
index 7a08a21..c535af8 100644
--- a/misc/computeshaderexamples/src/processors/computeshaderimageexample.cpp
+++ b/misc/computeshaderexamples/src/processors/computeshaderimageexample.cpp
@@ -78 +78 @@ void ComputeShaderImageExample::process() {
- TextureUnit unit;
+ const TextureUnit unit;
diff --git a/misc/computeshaderexamples/src/processors/computeshaderminmax.cpp b/misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
index 1ab2e6c..b0966a2 100644
--- a/misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
+++ b/misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
@@ -178,2 +178,2 @@ void ComputeShaderMinMax::process() {
- BufferObject buf(bufSize * sizeof(ivec4), GLFormats::get(DataFormatId::Vec4Float32),
- GL_DYNAMIC_READ, GL_SHADER_STORAGE_BUFFER);
+ const BufferObject buf(bufSize * sizeof(ivec4), GLFormats::get(DataFormatId::Vec4Float32),
+ GL_DYNAMIC_READ, GL_SHADER_STORAGE_BUFFER);
@@ -183 +183 @@ void ComputeShaderMinMax::process() {
- utilgl::Activate activateShader(&shaderSampleVolume_);
+ const utilgl::Activate activateShader(&shaderSampleVolume_);
@@ -186 +186 @@ void ComputeShaderMinMax::process() {
- TextureUnit texUnit;
+ const TextureUnit texUnit;
@@ -198 +198 @@ void ComputeShaderMinMax::process() {
- utilgl::Activate activateShader(&shaderLinear_);
+ const utilgl::Activate activateShader(&shaderLinear_);
@@ -219 +219 @@ void ComputeShaderMinMax::process() {
- DataMapper dataMapper{DataFormatBase::get(GLFormats::get(glFormat))};
+ const DataMapper dataMapper{DataFormatBase::get(GLFormats::get(glFormat))};
@@ -225 +225 @@ void ComputeShaderMinMax::process() {
- DataMapper dataMapper{
+ const DataMapper dataMapper{
Have any feedback or feature suggestions? Share it here.
misc/computeshaderexamples/src/processors/computeshaderimageexample.cpp
Outdated
Show resolved
Hide resolved
misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
Outdated
Show resolved
Hide resolved
misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
Outdated
Show resolved
Hide resolved
misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
Outdated
Show resolved
Hide resolved
misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
Outdated
Show resolved
Hide resolved
misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
Outdated
Show resolved
Hide resolved
misc/computeshaderexamples/src/processors/computeshaderminmax.cpp
Outdated
Show resolved
Hide resolved
493e7ed
to
14be6de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
Used clang-tidy v17.0.6
No concerns from clang-tidy.
Great job! 🎉
Have any feedback or feature suggestions? Share it here.
Example processor for determining min/max values of a volume using compute shaders.