Fix Python 2.6 support #75
Conversation
Travis CI uses exit codes to determine if tests pass. Unfortunately, we haven't been setting the exit code, so even when tests fail, the return code has been a success. Here's an example: https://travis-ci.org/ioerror/blockfinder/jobs/20337141 Now we check to see if any of the tests failed - and if they did, indicate a failure by returning the number of failed tests. This works because of bash's strange error handling - 0 is true (success), while 1-255 are false (failure).
In ioerror#69, explicit decoding of the lines was added. However, this was done using a keyword argument that isn't supported in Python 2.6. The good news is that there's no reason to use a keyword argument here - all versions take the same parameters. So if we just remove it, all is good.
|
Whoops, I duplicated this partially in #78. Sorry about that. |
|
@aagbsn - can you please open a pull request that pulls in the other On 3/15/14, aagbsn [email protected] wrote:
|
|
This should still merge cleanly and looks good to merge. |
|
Sounds good - thanks for the second set of eyes @aagbsn! |
|
I personally think we should be dropping support for python 2.6. |
|
I don't want to remove support for python 2.6 if we can manage to keep On 3/16/14, David [email protected] wrote:
|
|
@ioerror well to be specific, we need a distribution to ship with python >= 3.3. However, we do not need it to be the default python version used. |
In #69, explicit decoding of the lines was added. However, this was done using
a keyword argument that isn't supported in Python 2.6.
The good news is that there's no reason to use a keyword argument here - all
versions take the same parameters. So if we just remove it, all is good.
This was hidden by the CI always saying tests passed, so I fixed that as well.