Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Left and right swiping, added regret swipe #9

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

DaleWebb
Copy link

This has also been updated to use ._rAF()

@logoscreative
Copy link

I tested this out as posted here and got Uncaught TypeError: undefined is not a function on lines 220, 224, and 228. That blocked all the functionality. :(

@DaleWebb
Copy link
Author

Ah okay. Could you try now? I'm having trouble with my Chromebook - it
keeps corrupting files :( somehow the styling for the pane element has
disappeared.

I upgraded ionic to fix the "undefined is not a function" problem.

On 29 June 2014 13:12, Cliff Seal [email protected] wrote:

I tested this out as posted here and got Uncaught TypeError: undefined is
not a function on lines 220, 224, and 228. That blocked all the
functionality. :(


Reply to this email directly or view it on GitHub
#9 (comment)
.

@logoscreative
Copy link

Works much better! The only things I noticed currently are:

  1. I get another undefined... error when I click the card to flip.
  2. It might be too early here, but it seems like on-swipe-left and on-swipe-right are reversed.

@DaleWebb
Copy link
Author

Yeah, I had forgotten to add those functions to the isolate scope. It should work now

@paishin
Copy link

paishin commented Jul 15, 2014

@DaleWebb could you please also update the documentation with the new functionality?

Thanx a lot for your contribution, this saved me a LOT of work :D

@paishin
Copy link

paishin commented Jul 15, 2014

also...for me I need to replace all window.rAF() commands with window.requestAnimationFrame() in order to make it work...why is that?

@DaleWebb
Copy link
Author

Are you using the Chrome browser?

@paishin
Copy link

paishin commented Jul 16, 2014

Yes, I am using chrome / ionic beta.9

@DaleWebb
Copy link
Author

I replaced those calls too with window._rAF(), unless that is what you are referring to?

I think the window.rAF() stopped working from v0.9 onwards, so using my branch should work - I've been using v1.0.0.

I'll try and update the documentation today, as work has been slow...

@paishin
Copy link

paishin commented Jul 16, 2014

I think window.rAF() stopped working for me on v1.0.0 after Beta.7, I had to use the full command window.requestAnimationFrame() in order to make it work

@DaleWebb
Copy link
Author

Ah okay, this branch contains _rAF(), which works as far as I know

@paishin
Copy link

paishin commented Jul 16, 2014

What I am trying to say is that nor ._rAF() or .rAF() work for me only .requestAnimationFrame(). In any case, if someone else is facing this problem it is good to be documented. :)

@DaleWebb
Copy link
Author

Okay, I've changed that on mine and it appears to still work - so it is now
.requestAnimationFrame() :)

On 16 July 2014 12:52, paishin [email protected] wrote:

What I am trying to say is that nor ._rAF() or .rAF() work for me only
.requestAnimationFrame(). In any case, if someone else is facing this
problem it is good to be documented. :)


Reply to this email directly or view it on GitHub
#9 (comment)
.

@elianaxuefeng
Copy link

Hello. I noticed the latest version doesn't include the tap to flip anymore. I am very new to programming, and I was wondering how I can incorporate the swipe card with the tap to flip?

@DaleWebb
Copy link
Author

DaleWebb commented Apr 8, 2016

@elianaxuefeng, this pull request didn't get merged - if you clone this fork git clone [email protected]:DaleWebb/ionic-contrib-swipe-cards.git then you should get that functionality (from memory...)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants