fix func signature for empty param names (#1351)

* fix func signature for empty param names * add testcase
ionide · Jan 24, 2025 · 9277ff9 · 9277ff9
1 parent ed1bcf7
commit 9277ff9
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/src/FsAutoComplete.Core/SignatureFormatter.fs b/src/FsAutoComplete.Core/SignatureFormatter.fs
@@ -505,7 +505,13 @@ module SignatureFormatter =
           many
           |> List.map (fun (paramTypes) ->
             paramTypes
-            |> List.map (fun p -> formatName p + ":" ++ (formatParameter p))
+            |> List.map (fun p ->
+              let paramName = formatName p
+
+              if String.IsNullOrWhiteSpace(paramName) then
+                formatParameter p
+              else
+                paramName + ":" ++ (formatParameter p))
             |> String.concat (" * "))
           |> String.concat (" -> ")
 

diff --git a/test/FsAutoComplete.Tests.Lsp/CoreTests.fs b/test/FsAutoComplete.Tests.Lsp/CoreTests.fs
@@ -461,12 +461,19 @@ let tooltipTests state =
 #if NET8_0
               [ "active pattern ValueWithName: "
                 "   input: Expr"
-                "       -> option<obj * System.Type * string>" ]) ] ]
+                "       -> option<obj * System.Type * string>" ])
 #else
               [ "active pattern ValueWithName: "
                 "   input: Expr"
-                "       -> option<objnull * System.Type * string>" ]) ] ]
+                "       -> option<objnull * System.Type * string>" ])
 #endif
+          verifySignature
+            96u
+            7u
+            (concatLines
+              [ "interface IWithAndWithoutParamNames"
+                "  abstract member WithParamNames: arg1: int * arg2: float -> string"
+                "  abstract member WithoutParamNames: int * string -> int" ]) ] ]
 
 let closeTests state =
   // Note: clear diagnostics also implies clear caches (-> remove file & project options from State).

diff --git a/test/FsAutoComplete.Tests.Lsp/TestCases/Tooltips/Script.fsx b/test/FsAutoComplete.Tests.Lsp/TestCases/Tooltips/Script.fsx
@@ -93,3 +93,7 @@ type Awaitable =
       (awaitable: 'Awaitable)
       =
       awaitable.GetAwaiter()
+
+type IWithAndWithoutParamNames =
+    abstract member WithParamNames : arg1: int * arg2: float -> string
+    abstract member WithoutParamNames : int * string -> int