Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FCS and FSharp.Core for new release #208

Merged
merged 1 commit into from
May 15, 2024
Merged

update FCS and FSharp.Core for new release #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.65.0] - 2024-05-15

### Changed

* Updated F# Packages
* FSharp.Compiler.Service to 43.8.300
* FSharp.Core to 8.0.300

## [0.64.0] - 2024-04-21

### Added
Expand Down
6 changes: 3 additions & 3 deletions paket.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ NUGET
Expecto.TestResults (8.13.2)
Expecto (>= 8.13.2)
FSharp.Core (>= 4.6)
FSharp.Compiler.Service (43.7.400)
FSharp.Core (7.0.400)
FSharp.Compiler.Service (43.8.300)
FSharp.Core (8.0.300)
Comment on lines +24 to +25
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheAngryByrd two questions here:

  • This is quite a bump in terms of allowed FSharp.Core versions. Library guidelines suggest using the lowest-available FSharp.Core to help compat, but F.C is tightly bound to FCS. Is this fine for the ecosystem of consumers we have?
  • Since this FCS provides snapshots, do we want to grab/copy/modify the code you have in FSAC and provide helper functions here for mapping cracked projects to snapshots so that others can make use of it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a bump in terms of allowed FSharp.Core versions. Library guidelines suggest using the lowest-available FSharp.Core to help compat, but F.C is tightly bound to FCS. Is this fine for the ecosystem of consumers we have?

Yeah this part always kind of sucks.

The amount of surface area of FCS we use is pretty small and almost feels like it should be delivered as a source dependency. However if we want ProjectSnapshot we have to bump it and just deal with it unless we want to ship versions based on TFM or something. Speaking of ProjectSnapshot...

Since this FCS provides snapshots, do we want to grab/copy/modify the code you have in FSAC and provide helper functions here for mapping cracked projects to snapshots so that others can make use of it?

While I don't necessarily have a problem with it there's a few things to consider:

  1. FCS already provides a F# Options -> ProjectSnapshot which might be enough for most people's needs. It's another call but not really that detrimental.
  2. FSAC's implementation heavily tied to F# Data Adaptive. The Adaptive stuff is beneficial for longer lived services like FSAC, but for shorter one shot tools it's less necessary. And for longer lived services, I think that's what ProjectSystem is supposed to be.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - I did a quick spike of the adaptive stuff and came to the same conclusions. Thanks for sanity-checking me. I'll go ahead with this as it is then so we can continue the rollout.

System.Buffers (>= 4.5.1)
System.Collections.Immutable (>= 7.0)
System.Diagnostics.DiagnosticSource (>= 7.0.2)
Expand All @@ -33,7 +33,7 @@ NUGET
FSharp.Control.Reactive (5.0.5)
FSharp.Core (>= 4.7.2)
System.Reactive (>= 5.0 < 6.0)
FSharp.Core (7.0.400)
FSharp.Core (8.0.300)
GitHubActionsTestLogger (2.0.1)
Microsoft.TestPlatform.ObjectModel (>= 17.2)
Ionide.KeepAChangelog.Tasks (0.1.8) - copy_local: true
Expand Down
Loading