Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Proj-Info to use FCS and FSharp.Core from 9.0.100 #219

Merged
merged 13 commits into from
Nov 18, 2024

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Nov 14, 2024

Fixes #218 #214
Supplants #211

CONTRIBUTING.md Outdated Show resolved Hide resolved
src/Ionide.ProjInfo.Tool/Ionide.ProjInfo.Tool.fsproj Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I think the projectsystem project is missing versioning - will take a look

@baronfel
Copy link
Collaborator

baronfel commented Nov 18, 2024

Alright - the asset handling for the MSBuild packages is all set now. I also saw that one package wasn't getting a version - that was due to missing packagerefs on the build-time packages. I pushed those into Dir.build.props so that everything got them at the same time and in the same way.

I also added small READMEs to the packages so that the NuGet warnings were satisfied and users might have a slightly-better getting started experience.

After this I diff'd the local packages to the latest packages on NuGet.org and the content is structurally the same - with the exception that the Microsoft.Build packages no longer pollute callers. Now they will need to add their own MS.Build compile-time references, but the README for the Ionide.ProjInfo package includes those instructions.

@baronfel baronfel merged commit 0e15b52 into ionide:main Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Proj-Info to use FCS and FSharp.Core from 9.0.100
2 participants