Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BlockMetadataResponse #1009

Merged
merged 24 commits into from
Aug 22, 2023
Merged

Update BlockMetadataResponse #1009

merged 24 commits into from
Aug 22, 2023

Conversation

Thoralf-M
Copy link
Member

Update BlockMetadataResponse according to https://github.com/iotaledger/tips-draft/pull/24
Replaces #700

@Thoralf-M Thoralf-M marked this pull request as draft August 15, 2023 09:10
@Thoralf-M Thoralf-M marked this pull request as ready for review August 15, 2023 09:31
DaughterOfMars
DaughterOfMars previously approved these changes Aug 15, 2023
View reviewed changes
DaughterOfMars
DaughterOfMars previously approved these changes Aug 15, 2023
View reviewed changes
DaughterOfMars
DaughterOfMars previously approved these changes Aug 17, 2023
View reviewed changes
Thoralf-M and others added 21 commits August 21, 2023 21:19
@Thoralf-M
Fix example and test
e69c537
@Thoralf-M
Update sdk/tests/client/node_api/core.rs
2f069dd 
Co-authored-by: Alexandcoats <[email protected]>
@Thoralf-M
Rename TxFailureReason to TransactionFailureReason
d348dce
@Thoralf-M
Remove comment
7f3073b
@Thoralf-M
Address review comments
e3335e1
@Thoralf-M
Remove TransactionFailureReason::None
0879b41
@Thoralf-M
Update sdk/src/client/node_api/core/routes.rs
a7cb4d6
@Thoralf-M @thibault-martinez
Update sdk/src/types/block/semantic.rs
288f923 
Co-authored-by: Thibault Martinez <[email protected]>
@Thoralf-M
Update sdk/src/types/api/core/response.rs
b25da44
@Thoralf-M @thibault-martinez
Update sdk/src/types/api/core/response.rs
b5c4e2d 
Co-authored-by: Thibault Martinez <[email protected]>
@Thoralf-M
Rename
992b6be
@Thoralf-M
Cleanup comment
8c07a90
@Thoralf-M
Add TODO
de3013c
@Thoralf-M
Add #[non_exhaustive]
69c9db4
@Thoralf-M
Address review comments
9daed29
@Thoralf-M
Rename
311fe8b
@Thoralf-M
Address review comments
9c90b85
@Thoralf-M
Missing rename
221b5c9
@Thoralf-M @abdulmth
Update sdk/src/types/block/semantic.rs
240f72e 
Co-authored-by: Abdulrahim Al Methiab <[email protected]>
@Thoralf-M
Rename
be96499
@Thoralf-M
Remove unused import, Clippy
a5b413f
@Thoralf-M Thoralf-M merged commit 8c9f3ca into 2.0 Aug 22, 2023
19 checks passed
@Thoralf-M Thoralf-M deleted the BlockMetadataResponse branch August 22, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulmth abdulmth abdulmth approved these changes

@qrayven qrayven qrayven approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Thoralf-M @kwek20 @thibault-martinez @DaughterOfMars @qrayven @abdulmth