This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Test: Add rocksdb size profiling test #1705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
commented
Jan 15, 2020
| private static final Logger log = LoggerFactory.getLogger(RocksDbSizeProfiling.class); | ||
|
|
||
| @Test | ||
| public void profileDBSectionsSize() throws Exception { |
There was a problem hiding this comment.
GalRogozinski
commented
Jan 15, 2020
| private static final Logger log = LoggerFactory.getLogger(RocksDbSizeProfiling.class); | ||
|
|
||
| @Test | ||
| public void profileDBSectionsSize() throws Exception { |
There was a problem hiding this comment.
GalRogozinski
commented
Jan 15, 2020
| package com.iota.iri.profiling; | ||
|
|
||
| import com.iota.iri.conf.BaseIotaConfig; | ||
| import com.iota.iri.controllers.*; |
There was a problem hiding this comment.
kwek20
suggested changes
Feb 12, 2020
| log.info(String.format("Total (uncompressed): %.2f GB", sum / 1073741824 /* GB */)); | ||
| } finally { | ||
| log.info("----------------------------"); | ||
| localTangle.shutdown(); |
There was a problem hiding this comment.
maybe add a startup again, then log the db size on disk as well (compressed) and shutdown again.
as this restart forces rocksdb to write to disk :D
Code could be cleaner by reusing a new method for each/most VMs by accepting name, first vm and size to increase (although this is fine by me)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds adds an old profiling code that we had for some times to IRI's codebase.
It is better to add it officially to IRI's repo because it allows us to make sure it doesn't break due to change in IRI.
The motivation for finally merging is testing #1653.
In order to run it type:
mvn -Dtest=RocksDbSizeProfiling#profileDBSectionsSize test [-Ddbpath=/some/path]If
-Ddbpathis missing it defaults tomainnetdbFixes #936
Type of change
How Has This Been Tested?
The test ran successfully
Checklist:
Please delete items that are not relevant.