Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update w3dt-stewards group #82

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

aschmahmann
Copy link
Contributor

Summary

Updating the w3dt-stewards groups. While the group should probably be renamed, the group of people who should have permissions on the appropriate repos needed some updating.

Why do you need this?

Updating permissions (mostly removals, one addition).

Notes on the changes:

  • @laurentsenta @galargh: They have permissions where they need via the IPDX group
  • @BigLep @guseggert @Jorropo: They aren't operating in this group anymore, but happy to grant permissions if they need them to make like easier for any repos they contribute to
  • @achingbrain seemed like an oversight that he wasn't in this group earlier given his involvement with some of the managed repos

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@aschmahmann aschmahmann requested review from a team as code owners April 3, 2024 19:04
Copy link
Contributor

github-actions bot commented Apr 3, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User achingbrain:
  - will have the permission to ipfs-geoip change from push to admin
  - will gain pull permission to go-ds-gcs
  - will gain admin permission to ipfs-check
  - will gain maintain permission to ipfs-dns-deploy
  - will gain pull permission to ipfs-protocol-compliance-suite
  - will gain admin permission to js-mock-ipfs-pinning-service
  - will gain pull permission to nopfs
  - will gain admin permission to vole
User biglep:
  - will have the permission to ipfs-check change from admin to pull
  - will have the permission to ipfs-dns-deploy change from maintain to pull
  - will have the permission to ipfs-geoip change from admin to pull
  - will have the permission to js-mock-ipfs-pinning-service change from admin to pull
  - will have the permission to npm-on-ipfs change from admin to pull
  - will have the permission to vole change from admin to pull
User guseggert:
  - will have the permission to ipfs-check change from admin to pull
  - will have the permission to ipfs-dns-deploy change from maintain to pull
  - will have the permission to ipfs-geoip change from admin to pull
  - will have the permission to js-mock-ipfs-pinning-service change from admin to pull
  - will have the permission to npm-on-ipfs change from admin to pull
  - will have the permission to vole change from admin to pull
User jorropo:
  - will lose pull permission to go-ds-gcs
  - will lose admin permission to ipfs-check
  - will lose maintain permission to ipfs-dns-deploy
  - will lose admin permission to ipfs-geoip
  - will lose pull permission to ipfs-protocol-compliance-suite
  - will lose admin permission to js-mock-ipfs-pinning-service
  - will lose pull permission to nopfs
  - will lose admin permission to npm-on-ipfs
  - will lose admin permission to vole

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs-shipyard

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # github_repository.this["service-worker-gateway-2019-poc"] will be updated in-place
  ~ resource "github_repository" "this" {
        id                          = "service-worker-gateway-2019-poc"
      + merge_commit_message        = "PR_TITLE"
      + merge_commit_title          = "MERGE_MESSAGE"
        name                        = "service-worker-gateway-2019-poc"
      + squash_merge_commit_message = "COMMIT_MESSAGES"
      + squash_merge_commit_title   = "COMMIT_OR_PR_TITLE"
        # (24 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_team_membership.this["w3dt-stewards:achingbrain"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "4657018"
      + username = "achingbrain"
    }

  # github_team_membership.this["w3dt-stewards:biglep"] will be destroyed
  # (because key ["w3dt-stewards:biglep"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"db0e23b8a4710783be876420c8030d993e37ddb44d24ce322de3f0e572e9224c\"" -> null
      - id       = "4657018:BigLep" -> null
      - role     = "maintainer" -> null
      - team_id  = "4657018" -> null
      - username = "BigLep" -> null
    }

  # github_team_membership.this["w3dt-stewards:galargh"] will be destroyed
  # (because key ["w3dt-stewards:galargh"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"d5dc5725ae42ef3c08a39adbd62a411057fb0c7c8b93d7e9e68783f12d120b60\"" -> null
      - id       = "4657018:galargh" -> null
      - role     = "member" -> null
      - team_id  = "4657018" -> null
      - username = "galargh" -> null
    }

  # github_team_membership.this["w3dt-stewards:guseggert"] will be destroyed
  # (because key ["w3dt-stewards:guseggert"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"492e94ac73f046065428ee8a6a7716f80812b3522a74ebe2dc2ed14aa41fc54a\"" -> null
      - id       = "4657018:guseggert" -> null
      - role     = "member" -> null
      - team_id  = "4657018" -> null
      - username = "guseggert" -> null
    }

  # github_team_membership.this["w3dt-stewards:jorropo"] will be destroyed
  # (because key ["w3dt-stewards:jorropo"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"13c56320e2924b036f603975109d82c6ef23f9954593d0d68a142a8c77e53df8\"" -> null
      - id       = "4657018:Jorropo" -> null
      - role     = "member" -> null
      - team_id  = "4657018" -> null
      - username = "Jorropo" -> null
    }

  # github_team_membership.this["w3dt-stewards:laurentsenta"] will be destroyed
  # (because key ["w3dt-stewards:laurentsenta"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"570c1d5d2e409610d9da86c242086ddef89286815937b26d35e69f9057b68eaf\"" -> null
      - id       = "4657018:laurentsenta" -> null
      - role     = "member" -> null
      - team_id  = "4657018" -> null
      - username = "laurentsenta" -> null
    }

Plan: 1 to add, 1 to change, 5 to destroy.

@aschmahmann aschmahmann merged commit 710de9e into master Apr 3, 2024
6 checks passed
@aschmahmann aschmahmann deleted the chore/update-w3dtstewards branch April 3, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants