fix(ipns): reading records with raw []byte Value #830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve / maximize interop with legacy/alternative IPNS clients by restoring support for
[]byte
CID inValue
field and gracefully handling emptyValue
in scenarios where IPNS is used for itsData
field, and not IPFS paths.record.Value()
will convert a binary CID to a validpath.Path
.Value()
will produceNoopPath
(/ipfs/bafkqaaa
) to avoid breaking existing code that expects a valid record to always produce a valid content path.Value()
can't produce a meaningful pathThank you @ianopolous and @aschmahmann for catching this.
If / once this lands, I'll update phrasing in https://specs.ipfs.tech/ipns/ipns-record/ to make it clear binary CID and empty Value are both allowed.
Aiming to include this in Kubo 0.34.