Cleanup permissions for shipyard maintained repos #211
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -641,15 +641,13 @@ repositories: | |
| squash_merge_commit_title: PR_TITLE | ||
| teams: | ||
| admin: | ||
| - ipdx | ||
| - kubo maintainers | ||
| maintain: | ||
| - shipyard | ||
| push: | ||
| - Merge - Go | ||
| - Repos - Go | ||
| topics: | ||
| - go | ||
| - ipfs | ||
|
|
@@ -3385,9 +3383,6 @@ repositories: | |
| restrict_dismissals: false | ||
| required_status_checks: | ||
| strict: true | ||
| default_branch: main | ||
| description: Run helia as a daemon process | ||
| files: | ||
|
|
@@ -3405,8 +3400,8 @@ repositories: | |
| teams: | ||
| admin: | ||
| - helia-dev | ||
| maintain: | ||
| - shipyard | ||
| push: | ||
| - Repos - JavaScript | ||
| topics: | ||
|
|
@@ -3421,8 +3416,6 @@ repositories: | |
| allow_update_branch: true | ||
| archived: false | ||
| collaborators: | ||
| push: | ||
| - web3-bot | ||
| default_branch: main | ||
|
|
@@ -3443,9 +3436,8 @@ repositories: | |
| admin: | ||
| - helia-dev | ||
| - ipdx | ||
|
Comment on lines
-3450
to
-3451
There was a problem hiding this comment. @ipfs/ipdx any idea why these pull permissions got added everywhere in fe64a02? There was a problem hiding this comment. Yes! This is because So, unfortunately, they're going to come back, but you don't necessarily have to restore them yourself. The apply should go through anyway, and the config will be updated during the weekly sync. |
||
| maintain: | ||
| - shipyard | ||
| push: | ||
| - Repos - JavaScript | ||
| topics: | ||
|
|
@@ -3455,10 +3447,6 @@ repositories: | |
| advanced_security: false | ||
| allow_update_branch: true | ||
| archived: false | ||
| default_branch: main | ||
| description: Run Helia NodeJS in a Docker Container. | ||
| files: | ||
|
|
@@ -3476,8 +3464,8 @@ repositories: | |
| teams: | ||
| admin: | ||
| - helia-dev | ||
| maintain: | ||
| - shipyard | ||
| topics: | ||
| - docker | ||
| - helia-nodejs | ||
|
|
@@ -3493,9 +3481,6 @@ repositories: | |
| advanced_security: false | ||
| allow_update_branch: false | ||
| archived: false | ||
| default_branch: main | ||
| description: A library that helps Helia consumers pin content via the | ||
| https://ipfs.github.io/pinning-services-api-spec/. Initial design at | ||
|
|
@@ -3515,8 +3500,8 @@ repositories: | |
| teams: | ||
| admin: | ||
| - helia-dev | ||
| maintain: | ||
| - shipyard | ||
| topics: | ||
| - helia | ||
| - ipfs-helia | ||
|
|
@@ -3552,9 +3537,8 @@ repositories: | |
| admin: | ||
| - helia-dev | ||
| - ipdx | ||
| maintain: | ||
| - shipyard | ||
| push: | ||
| - Repos - JavaScript | ||
| visibility: public | ||
|
|
@@ -3603,9 +3587,8 @@ repositories: | |
| admin: | ||
| - helia-dev | ||
| - ipdx | ||
| maintain: | ||
| - shipyard | ||
| push: | ||
| - Repos - JavaScript | ||
| topics: | ||
|
|
@@ -5256,9 +5239,7 @@ repositories: | |
| enforce_admins: false | ||
| lock_branch: false | ||
| push_restrictions: | ||
| - ipfs/kubo-maintainers | ||
|
Comment on lines
5198
to
+5199
There was a problem hiding this comment. @ipfs/ipdx how can I set this to push restrictions on, but with no associated group? IIUC there's nothing you can do anyway to stop admins from pushing (or maintainers from pushing with approval) so adding groups here seems unnecessary provided you can keep the restrictions enabled. |
||
| require_conversation_resolution: false | ||
| require_signed_commits: false | ||
| required_linear_history: false | ||
|
|
@@ -5269,8 +5250,7 @@ repositories: | |
| enforce_admins: false | ||
| lock_branch: false | ||
| push_restrictions: | ||
| - ipfs/kubo-maintainers | ||
| require_conversation_resolution: false | ||
| require_signed_commits: false | ||
| required_linear_history: false | ||
|
|
@@ -5280,6 +5260,8 @@ repositories: | |
| blocks_creations: false | ||
| enforce_admins: false | ||
| lock_branch: false | ||
| push_restrictions: | ||
| - ipfs/kubo-maintainers | ||
| require_conversation_resolution: false | ||
| require_signed_commits: false | ||
| required_linear_history: false | ||
|
|
@@ -5303,11 +5285,6 @@ repositories: | |
| blocks_creations: false | ||
| enforce_admins: true | ||
| lock_branch: false | ||
| require_conversation_resolution: false | ||
| require_signed_commits: false | ||
| required_linear_history: false | ||
|
|
@@ -5317,12 +5294,6 @@ repositories: | |
| blocks_creations: false | ||
| enforce_admins: false | ||
| lock_branch: false | ||
| require_conversation_resolution: false | ||
| require_signed_commits: false | ||
| required_linear_history: false | ||
|
|
@@ -5340,11 +5311,6 @@ repositories: | |
| - go-test | ||
| - sharness-test | ||
| strict: true | ||
|
There was a problem hiding this comment. @dennis-tra I'm removing your permissions here and there will be a follow up PR to add you to the IPFS org and from there you can get added to any teams you need to be. There was a problem hiding this comment. Sounds good, thanks for the heads-up! 👍 |
||
| default_branch: master | ||
| description: An IPFS implementation in Go | ||
| files: | ||
|
|
@@ -5361,15 +5327,12 @@ repositories: | |
| squash_merge_commit_title: COMMIT_OR_PR_TITLE | ||
| teams: | ||
| admin: | ||
| - kubo maintainers | ||
| maintain: | ||
| - shipyard | ||
| pull: | ||
| - contributors | ||
| push: | ||
| - Merge - Go | ||
| - Repos - Go | ||
| topics: | ||
|
|
@@ -5809,12 +5772,10 @@ repositories: | |
| squash_merge_commit_title: COMMIT_OR_PR_TITLE | ||
| teams: | ||
| admin: | ||
| - ipdx | ||
aschmahmann marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - kubo maintainers | ||
| maintain: | ||
| - shipyard | ||
|
Comment on lines
+5732
to
+5733
There was a problem hiding this comment. @lidel WDYT about giving push to repos Go for rainbow and someguy? There was a problem hiding this comment. Probably ok, that group already has "maintain" in boxo, so push will make it easier for existing community to submit PRs. ps. there is a separate long-term meta-worry in that there is way too many people in https://github.com/orgs/ipfs/teams/repos-go, and if our intention is to limit security risks / access, we should plan to subset that group. |
||
| topics: | ||
| - http | ||
| - ipfs-gateway | ||
|
|
@@ -5916,13 +5877,6 @@ repositories: | |
| require_conversation_resolution: false | ||
| require_signed_commits: false | ||
| required_linear_history: false | ||
| default_branch: main | ||
| description: "[WIP EXPERIMENT] IPFS Gateway implemented in Service Worker" | ||
| files: | ||
|
|
@@ -5936,9 +5890,9 @@ repositories: | |
| squash_merge_commit_message: COMMIT_MESSAGES | ||
| squash_merge_commit_title: COMMIT_OR_PR_TITLE | ||
| teams: | ||
| admin: | ||
| - helia-dev | ||
| - shipyard | ||
| topics: | ||
| - helia | ||
| - ipfs-gateway | ||
|
|
@@ -6021,12 +5975,10 @@ repositories: | |
| squash_merge_commit_title: COMMIT_OR_PR_TITLE | ||
| teams: | ||
| admin: | ||
| - ipdx | ||
| - kubo maintainers | ||
| maintain: | ||
| - shipyard | ||
| topics: | ||
| - ipfs | ||
| - p2p | ||
|
|
@@ -6482,7 +6434,6 @@ teams: | |
| member: | ||
| - 2color | ||
| - SgtPooki | ||
| privacy: closed | ||
| ipdx: | ||
| members: | ||
|
|
@@ -6509,7 +6460,6 @@ teams: | |
| member: | ||
| - aschmahmann | ||
| - gammazero | ||
| privacy: closed | ||
| Maintainers: | ||
| description: People with Maintainer access to all repositories | ||
|
|
@@ -6607,6 +6557,19 @@ teams: | |
| - vmx | ||
| - wemeetagain | ||
| privacy: closed | ||
| shipyard: | ||
| description: Members of Interplanetary Shipyard who work with or on IPFS | ||
| members: | ||
| maintainer: | ||
| - aschmahmann | ||
| - lidel | ||
| member: | ||
| - 2color | ||
| - achingbrain | ||
| - gammazero | ||
| - guillaumemichel | ||
| - MarcoPolo | ||
| - SgtPooki | ||
| Specs Stewards: | ||
| description: IPFS Specifications Stewards | ||
| members: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achingbrain @SgtPooki I added Shipyard as maintainers for some repos where there were no ambient admin permissions for the "admin" or w3dt-stewards teams. It might be that these are unnecessary or should just be push permissions. Happy to downgrade if you think that makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be fine, and we haven't touched helia-cli in a while, and likely won't