-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable/set depth limit #25
Comments
@MarshalX would it help if the |
The `Codec` trait from `ipld-core` allows unified access for encoding, decoding and extracting links of encoded IPLD data independent of the codec. This commit also makes the `Deserializer` public, so that it can be used for `ipld-extract-links`. Having it public should also help with issue #25.
The `Codec` trait from `ipld-core` allows unified access for encoding, decoding and extracting links of encoded IPLD data independent of the codec. It only works when the `no-cid-as-bytes` feature is disabled, because the link extraction code is based on Serde. This commit also makes the `Deserializer` public, so that it can be used for `ipld-extract-links`. Having it public should also help with issue #25.
The `Codec` trait from `ipld-core` allows unified access for encoding, decoding and extracting links of encoded IPLD data independent of the codec. It only works when the `no-cid-as-bytes` feature is disabled, because the link extraction code is based on Serde. This commit also makes the `Deserializer` public, so that it can be used for `ipld-extract-links`. Having it public should also help with issue #25.
@MarshalX In the most recent release is the |
hi @vmx and thank you for your effort! i'm a bit busy these days but i'll try to verify as soon as i can. sorry for the long response |
Hello! cbor4ii's decoder comes with deep limit which could be disabled/increased by implementing own
dec::Read
. Butserde_ipld_dagcbor
implements it's own including deep limit. So I'm wondering is there any simple way to disable/increase it? For now i just copiedde.rs
to my codebase which is not prettyI use
serde_ipld_dagcbor
like this:serde_ipld_dagcbor/src/lib.rs
Lines 69 to 78 in ffae329
upd. as i understand
serde_ipld_dagcbor
doesn't tune depth limit at all. so the default (256) comes fromcbor4ii
. which is too small for meThe text was updated successfully, but these errors were encountered: