feat: implement Codec trait #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
force-pushed
the
codec-trait
branch
2 times, most recently
from
845b430 to
2244a89
Compare
The `Codec` trait from `ipld-core` allows unified access for encoding, decoding and extracting links of encoded IPLD data independent of the codec. It only works when the `no-cid-as-bytes` feature is disabled, because the link extraction code is based on Serde. This commit also makes the `Deserializer` public, so that it can be used for `ipld-extract-links`. Having it public should also help with issue #25.
Stebalien
approved these changes
Mar 14, 2024
|
The only difference to the already approved version is, that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Codectrait fromipld-coreallows unified access for encoding,decoding and extracting links of encoded IPLD data independent of the
codec. It only works when the
no-cid-as-bytesfeature is disabled,because the link extraction code is based on Serde.
This commit also makes the
Deserializerpublic, so that it can beused for
ipld-extract-links. Having it public should also help withissue #25.