Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including importnb into ipynb #46

Open
wants to merge 379 commits into
base: master
Choose a base branch
from
Open

Conversation

tonyfast
Copy link

@tonyfast tonyfast commented Jan 2, 2020

addresses #45 starts to include the importnb machinery in the ipynb repo.

importnb has features that address a few open issues #38 #6 #44

  • In the short term should we include both ipynb and importnb in the namespace?
  • Should we change importnb to ipynb or retain importnb?

tonyfast and others added 26 commits October 23, 2018 07:07
* Rename extensions to defaults
* Finish renaming extensions
* Remove helpers
* More human api loader names
* More flexible extension installer
* Update the api
* Remove helpers from init
* Fix remote
* New plugin approach
* Update _version.py
* Make modules pathlike

* Make pathlike a little more robust
Use store_true and store_false for boolean parameterizations
… is a __path__ atribute in the namespace. (#83)
* Rearrange pytest and add stricter testing functions with nbsource

* Simplify the pytest doctest module test collection
* Add better tracebacks to the loader

* Update extension

* Update pytest_nbsource.py

Add encoding the path opener.

* Update test_importnb.ipynb
* Remove the classic_input transformer so doctests are always there
* Update loader.ipynb
* Add ast parser to create tests from string expressions
* Add test for new __test__ attribute
* Remove triple ticks from docstrings.
* Only transform triple ticks on new lines.
* Remove fstring
* Make joinedstr optional
* Change the name of th pytest plugin and enhance the support of doctests from other loaders.
* Update _version.py
* readme

* Update pytest_importnb.py

Move function
* paramterize optional

* drop notebooks

* Update loader.py

Add support for python 3.8
Remove doctests now that the notebooks are removed from the package.

* Update test_importnb.ipynb

* Update parameterize.py

support 3.8

* Update MANIFEST.in

* Update parameterize.py

cruft

* Update readme.ipynb

relative import parameterize

* update readme

* Update _version.py

bump version
* blacken

* isort

* Update readme.ipynb

add black logo
@yuvipanda
Copy link
Collaborator

woohoo, awesome.

I think what we should do is:

  1. Emit warnings from ipynb about pending changes, and make a point release
  2. Emit warnings from importnb about pending move, and make a point release there.
  3. Move importnb into the ipynb namespace. Write docs on how people can switch. Make a major release.
  4. Write a blog post.

How does that sound?

@yuvipanda
Copy link
Collaborator

@Carreau I don't have admin access to this repo, can you add @tonyfast and @bollwyvl to this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants