Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve integration of ml task #153

Merged
merged 13 commits into from
Jun 9, 2023

Conversation

ekauffma
Copy link
Collaborator

@ekauffma ekauffma commented Jun 7, 2023

This PR partially addresses issue #130 with the following features:

  • fix: get rid of unnecessary particle dependency
  • first plots of ML features are turned into a grid of plots to save space
  • USE_INFERENCE flag required for ML model fitting
  • get_query method updated to accommodate new cuts and selectively provide branches needed for ML features depending on flag USE_INFERENCE

Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of some of these follow-up items! Does the new query pass the histogram comparison script?

@ekauffma
Copy link
Collaborator Author

ekauffma commented Jun 9, 2023

I am not sure... the query takes forever to run, but I will go ahead and test this

@ekauffma
Copy link
Collaborator Author

ekauffma commented Jun 9, 2023

Update: histogram with SERVICEX=True is verified

@alexander-held alexander-held merged commit 05b5322 into iris-hep:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants