feat: updated validation script to check partial bin sums #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguiraud
reviewed
Jun 29, 2023
There was a problem hiding this comment.
thanks @ekauffma , I would have approved the PR but I don't have enough permission to do so, I can only comment 😄
I could not completely follow the logic in my head, so sorry if some of the comments don't make sense. Even with the comments, that you can feel free to disregard, this overall LGTM.
|
@eguiraud I made a lot of edits inspired by your suggestions. I would appreciate if you would read again and let me know if you find it easier to follow now! Thank you |
eguiraud
reviewed
Jun 30, 2023
alexander-held
approved these changes
Jul 4, 2023
alexander-held
changed the title
eguiraud
pushed a commit
to eguiraud/analysis-grand-challenge-coffea
that referenced
this pull request
Jul 19, 2023
* updated validation script to check partial bin sums * added verbose flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #168 . If adjacent bins are similar enough, the partial sum of the affected bins is compared. This will ensure that one event migrating across bins will not flag as an error. Maybe we can test this with RDF implementation (@andriiknu)
@alexander-held @eguiraud