Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Franck Buijs (currently in internship) uses an
attelo
-independent learner for his experiments, and got hard-to-debug behavior upon decoding.NaN
scores passed silently to the MST algorithm until something crashed the algorithm.This PR adds a check to the MST decoder for
NaN
scores. I'm investigating if the check should be propagated to the other decoders, or if the check should be made at a higher level.