Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#433,irods/irods#7838,irods/irods#8122] Fix EL8 build, remove old centos support code (main) #515

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

SwooshyCueb
Copy link
Member

In service of #433
In service of irods/irods#7838
Addresses irods/irods#8122 for main

@alanking alanking changed the title [#433,irods/irods#7838,irods/irods#8122] Fix EL8 build, remove old centos support code [#433,irods/irods#7838,irods/irods#8122] Fix EL8 build, remove old centos support code (main) Jan 21, 2025
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion, one question

src/ierror.cpp Outdated Show resolved Hide resolved
src/ienv.cpp Show resolved Hide resolved
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me... Let's get one more approval before #'ing.

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@SwooshyCueb
Copy link
Member Author

#'d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants