Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick for skipping BytesBuf serialization #89

Open
wants to merge 2 commits into
base: 4-2-7-stable
Choose a base branch
from

Conversation

trel
Copy link
Member

@trel trel commented May 12, 2022

No description provided.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested? @korydraughn?

@korydraughn
Copy link
Contributor

No. I have not tested this.

@alanking
Copy link
Contributor

Okay, just checking. Let's leave it til we can make sure this is okay. I don't foresee any issues. I can have a look tomorrow.

@kript
Copy link

kript commented May 17, 2022

How is this coming on folks? Any ETA for a release?

@trel
Copy link
Member Author

trel commented May 17, 2022

You're interested in an Ubuntu18 package?

@alanking
Copy link
Contributor

Running these tests will be a little less trivial than I first imagined because of the test hook and the age of 2.7.x. Promise I'll get to this soon. "Tomorrow" was a bit ambitious last time.

@kript
Copy link

kript commented May 17, 2022

You're interested in an Ubuntu18 package?

I'm afraid so!

@trel
Copy link
Member Author

trel commented May 17, 2022

I've sent an engineering build for your testing/approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants