Fix dpservice-cli crash when running before initialisation #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlorinc
force-pushed
the
fix/dpservice-cli/crash_before_init
branch
from
2138bf5 to
6a6fefb
Compare
guvenc
reviewed
Jan 27, 2025
|
@vlorinc |
- change in dpservice-go library: unified the return values of gRPC functions - this fixes #639; empty struct is now always returned and accessing Status.Code field doesn't crash dpservice-cli - changes in dpservice-cli: removed checking for Status.Code as it is handled by error value - removed the check of Status.Code from RenderList(), Status is checked before, errorous Lists are not rendered and error is returned
vlorinc
force-pushed
the
fix/dpservice-cli/crash_before_init
branch
from
6a6fefb to
65b4ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify error handling accross all commands
Fixes #639