Skip to content

Commit

Permalink
Change default webhook server port in test suite
Browse files Browse the repository at this point in the history
  • Loading branch information
afritzler committed Sep 13, 2024
1 parent afd1de4 commit 7c2c11e
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions api/v1alpha1/webhook_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ var _ = BeforeSuite(func() {
// Note that you must have the required binaries setup under the bin directory to perform
// the tests directly. When we run make test it will be setup and used automatically.
BinaryAssetsDirectory: filepath.Join("..", "..", "bin", "k8s",
fmt.Sprintf("1.29.0-%s-%s", runtime.GOOS, runtime.GOARCH)),
fmt.Sprintf("1.30.0-%s-%s", runtime.GOOS, runtime.GOARCH)),

WebhookInstallOptions: envtest.WebhookInstallOptions{
Paths: []string{filepath.Join("..", "..", "config", "webhook")},
Expand Down Expand Up @@ -111,7 +111,7 @@ var _ = BeforeSuite(func() {
CertDir: webhookInstallOptions.LocalServingCertDir,
}),
LeaderElection: false,
Metrics: metricsserver.Options{BindAddress: "0"},
Metrics: metricsserver.Options{BindAddress: ":8081"},
})
Expect(err).NotTo(HaveOccurred())

Expand All @@ -122,8 +122,7 @@ var _ = BeforeSuite(func() {

go func() {
defer GinkgoRecover()
err = mgr.Start(ctx)
Expect(err).NotTo(HaveOccurred())
Expect(mgr.Start(ctx)).NotTo(HaveOccurred())
}()

// wait for the webhook server to get ready
Expand Down

0 comments on commit 7c2c11e

Please sign in to comment.