Allow the discovery of Servers which are in the powered On state.
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
force-pushed
the
enh/initial-state
branch
from
ed8b987 to
726960a
Compare
Currently we are not running the discovery of `Servers` which are already powered `On`. A new flag (`--enforce-first-boot`) has been introduced to enforce the discovery of already powered on `Servers`. The default of this flag is set to `false`. Additionally if we encounter a `Server` with `.spec.power==""` in the initial state, we mutate the `Server` spec to macht the detected `PowerState` in the `Servers` status. Co-authored-by: Hardik Dodiya <[email protected]>
afritzler
force-pushed
the
enh/initial-state
branch
from
726960a to
5ad409c
Compare
afritzler
commented
Aug 15, 2024
| server.Status.State = metalv1alpha1.ServerStateAvailable | ||
| })).Should(Succeed()) | ||
|
|
||
| By("Ensuring that the Server has the correct claim ref") | ||
| Eventually(Object(&server)).Should(SatisfyAll( | ||
| HaveField("Spec.ServerClaimRef.Name", claim.Name), | ||
| Eventually(Object(server)).Should(SatisfyAll( |
There was a problem hiding this comment.
@defo89 that was the reason for the sporadic test failures which we encountered. Eventually .spec.ServerClaimRef.Name was set but if not the test ran into a nil pointer deref.
afritzler
force-pushed
the
enh/initial-state
branch
5 times, most recently
from
11fffff to
1657543
Compare
afritzler
force-pushed
the
enh/initial-state
branch
from
1657543 to
f0bf450
Compare
afritzler
force-pushed
the
enh/initial-state
branch
from
06669d2 to
4e0df6a
Compare
|
The sporadic issues in the controller suite seems to be fixed now. But there seems to be still an issue in the registry and agent tests. Somehow it looks like the registry server can't be started as (maybe) the port can't be allocated. 🤔 |
afritzler
force-pushed
the
enh/initial-state
branch
from
1935714 to
f85307e
Compare
afritzler
force-pushed
the
enh/initial-state
branch
from
f85307e to
227d47d
Compare
hardikdr
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Currently we are not running the discovery of
Serverswhich are already poweredOn. A new flag (--enforce-first-boot) has been introduced to enforce the discovery of already powered onServers. The default of this flag is set tofalse.Additionally if we encounter a
Serverwith.spec.power == ""in the initial state, we mutate theServerspec to match the detectedPowerStatein theServersstatus.Also some sporadic test failures where addressed.
Fixes #103 #108