-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry with ForcePowerOff
if graceful shutdown times out
#129
Conversation
hmm, need to revisit. For Dell it has worked, but on Lenovo I get
|
781c969
to
12d4346
Compare
Power off
if graceful shutdown times outForcePowerOff
if graceful shutdown times out
I observed that in case `Server` is stuck in a failed PXE Boot or in other non-responsive state, `redfish.GracefulShutdownResetType` would not power off the system. So we can retry with `redfish.ForcePowerOff` if above fails.
12d4346
to
25434a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Maybe @stefanhipfel can also have a lot at this PR.
lgtm as well. |
good point. I'd see |
Proposed Changes
Server
is stuck in a failed PXE Boot or in other non-responsive state,redfish.GracefulShutdownResetType
would not power off the system.redfish.PushPowerButtonResetType
if above fails.--enforce-power-off