Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requeue for Power state polling and ensuringServerClaim binding #131

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Sep 18, 2024

Proposed Changes

  • Requeue Available and Reserved servers to reconcile and poll power states
  • To avoid setting PXE boot for all reserved Servers we only set it if it's powered off - when server transitions from Available (and is powered off) to Reserved
  • reconcile unbound ServerClaim when Server (e.g. label) is changed - to re-check available servers if no server was found for claim initially

@defo89 defo89 added the enhancement New feature or request label Sep 18, 2024
internal/controller/serverclaim_controller.go Outdated Show resolved Hide resolved
internal/controller/serverclaim_controller.go Outdated Show resolved Hide resolved
internal/controller/server_controller.go Show resolved Hide resolved
@defo89 defo89 force-pushed the enh/requeue-for-polling branch from 0089de0 to 945c7a8 Compare September 19, 2024 10:02
@defo89 defo89 requested a review from afritzler September 19, 2024 10:17
cmd/manager/main.go Outdated Show resolved Hide resolved
- Requeue `Available` and `Reserved` servers to reconcile and poll power states
- To avoid setting PXE boot for all reseved `Servers` we only set it if it's powered off - when server transitions from `Available` (and is powered off) to `Reserved`
- reconcile unbound `ServerClaim` when `Server` (e.g. label) is changed - to re-check available servers if no server was found for claim initially
@defo89 defo89 force-pushed the enh/requeue-for-polling branch from 945c7a8 to 6e0665f Compare September 19, 2024 13:21
@github-actions github-actions bot added size/S and removed size/M labels Sep 19, 2024
cmd/manager/main.go Outdated Show resolved Hide resolved
@defo89 defo89 requested a review from afritzler September 19, 2024 13:21
@defo89 defo89 merged commit 9db317b into main Sep 19, 2024
8 checks passed
@defo89 defo89 deleted the enh/requeue-for-polling branch September 19, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants