Extract storage details of a Server using Redfish
#143
Conversation
| } | ||
| } | ||
| if len(result) == 0 { | ||
| // if no storage is found, fall back to simpleStorage (outdated storage API) |
There was a problem hiding this comment.
redfish-mockup-server only supports simpleStorage and just returns an empty list for Storage.
| serverBase := server.DeepCopy() | ||
| server.Status.Storages = nil | ||
| for _, storage := range storages { |
There was a problem hiding this comment.
do we need to keep checking storages on every updateServerStatus? This is anyway only possible when using redfish, but I would say this is only needed when a server is put back to state initial.
There was a problem hiding this comment.
I would keep the reconciliation logic as is. Yes, the information is typically stable - but when it changes we won't know + if somebody changes manually the status we won't get notified either.
afritzler
changed the title
Server using Redfish
|
Can you run |
| Vendor string `json:"vendor,omitempty"` | ||
| // Model specifies the model of the storage device. | ||
| Model string `json:"model,omitempty"` | ||
| State common.State `json:"state,omitempty"` |
There was a problem hiding this comment.
Can we add a comment to this field.
github-actions
bot
added
the
documentation
No description provided.