Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metalctl console subcommand #201

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Add metalctl console subcommand #201

merged 2 commits into from
Dec 12, 2024

Conversation

afritzler
Copy link
Member

Proposed Changes

  • Add a metalctl console subcommand with which you are able to connect to a Servers serial console
  • Factor out bmcutils into an own package

@github-actions github-actions bot added enhancement New feature or request size/XL labels Dec 9, 2024
@afritzler afritzler force-pushed the enh/serial-console branch 6 times, most recently from dbd6479 to 600f99e Compare December 9, 2024 14:35
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 9, 2024
@afritzler afritzler force-pushed the enh/serial-console branch 4 times, most recently from 0985f71 to 2e2df22 Compare December 11, 2024 08:19
@afritzler afritzler marked this pull request as ready for review December 11, 2024 08:45
SzymonSAP
SzymonSAP reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@SzymonSAP SzymonSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is well written and there is not much to point out but I found 3 fast fixes to be done. Good job! ;)

cmd/metalctl/app/console.go Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
@afritzler
Add metalctl console subcommand
bd03518 
- Add a `metalctl console` subcommand with which you are able to connect
  to a `Servers` serial console
- Factor out `bmcutils` into an own package
@afritzler afritzler merged commit ff5dc62 into main Dec 12, 2024
8 checks passed
@afritzler afritzler deleted the enh/serial-console branch December 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SzymonSAP SzymonSAP SzymonSAP left review comments

@Nuckal777 Nuckal777 Nuckal777 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afritzler @Nuckal777 @SzymonSAP