-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Discovery
State and rework Initial
power/pxe handling
#98
Conversation
a7c0788
to
1b8f3b7
Compare
1b8f3b7
to
aba2ae3
Compare
Discovery
State and rework Initial
power/pxe handling
f09eab1
to
9932ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we have a quick offline discussion next week before we go ahead here. I have a few points I’d like to cover:
-
Could we leverage the NodeConditions like API instead of introducing a new state? This might streamline the integration without altering the state machine significantly.
-
The rationale for always using PXEBootOnce is to ensure that the Metal Machine consistently fetches the latest PXE script and Ignition during Initial state. Since the OS runs in-memory, especially with Gardenlinux, avoiding PXE could result in the machine booting from disk, which might lead to unexpected behaviors.
-
Regarding the issue with machines that are already powered on, perhaps a hint in the Endpoint object about whether Servers should undergo a Firstboot or be directly moved to Available during onboarding might offer a more holistic solution.
@defo89 can you also run |
9932ff1
to
c16ccb9
Compare
thanks for the hint - done |
Proposed Changes
Discovery
state where we expect server to PXE boot and post to registryInitial
server and proceed toDiscovery
state. With this we do not send PXE boot all the time while metal server is booting upOn theFor now, we need to power off the server manually if it's onInitial
state we power off the server regardless, hence no need to cover server that is powered onFixes #97